Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing issue #161 #164

Merged
merged 1 commit into from
Apr 3, 2022
Merged

Fixing issue #161 #164

merged 1 commit into from
Apr 3, 2022

Conversation

napolux
Copy link
Collaborator

@napolux napolux commented Mar 13, 2022

See #161

Thanks https://github.com/rex for the fix :)

@gioxx please check if we want to go directly to master or a new release branch. In that case I can change the base branch

@napolux napolux requested review from gioxx and sherkot March 13, 2022 08:32
@napolux napolux self-assigned this Mar 13, 2022
@gioxx
Copy link
Owner

gioxx commented Mar 13, 2022

We can use the master branch for sure.

@rex
Copy link

rex commented Mar 16, 2022

You rock @napolux. I have opened a separate PR #167 that expands on my original fixes

@napolux napolux merged commit 15b3f56 into gioxx:master Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gioxx gioxx Awaiting requested review from gioxx

@sherkot sherkot Awaiting requested review from sherkot

Assignees

@napolux napolux

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@napolux @gioxx @rex