Minimal Giraffe App #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TheAngryByrd should this one get squashed or dropped? |
slang25
reviewed
Sep 4, 2023
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
| <TargetFramework>net7</TargetFramework> | |||
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net7</TargetFramework> | |
| <TargetFramework>net7.0</TargetFramework> |
slang25
reviewed
Sep 4, 2023
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
| <TargetFramework>net7</TargetFramework> | |||
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net7</TargetFramework> | |
| <TargetFramework>net7.0</TargetFramework> |
slang25
reviewed
Sep 4, 2023
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
| <TargetFramework>net7</TargetFramework> | |||
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net7</TargetFramework> | |
| <TargetFramework>net7.0</TargetFramework> |
slang25
reviewed
Sep 4, 2023
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
| <TargetFramework>net7</TargetFramework> | |||
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net7</TargetFramework> | |
| <TargetFramework>net7.0</TargetFramework> |
slang25
reviewed
Sep 4, 2023
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk.Web"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFramework>netcoreapp3.1</TargetFramework> | |||
| <TargetFramework>net7</TargetFramework> | |||
There was a problem hiding this comment.
Suggested change
| <TargetFramework>net7</TargetFramework> | |
| <TargetFramework>net7.0</TargetFramework> |
slang25
reviewed
Sep 4, 2023
appveyor.yml
Outdated
| - Ubuntu | ||
| environment: | ||
| DOTNET_CLI_TELEMETRY_OPTOUT: 1 | ||
| init: | ||
| - git config --global core.autocrlf true | ||
| install: | ||
| - ps: .\.psscripts\install-dotnet.ps1 -SdkVersions "3.1.201" | ||
| - ps: .\.psscripts\install-dotnet.ps1 -SdkVersions "7.0.307" |
There was a problem hiding this comment.
Suggested change
| - ps: .\.psscripts\install-dotnet.ps1 -SdkVersions "7.0.307" | |
| - ps: .\.psscripts\install-dotnet.ps1 -SdkVersions "7.0.400" |
There was a problem hiding this comment.
Nice @slang25 , I think those changes are already merged, so the suggestions should go into a separate PR. I need to rebase this PR in order for it to show only the relevant changes.
There was a problem hiding this comment.
I've rebased, so the actual changes should be only two files.
wallymathieu
force-pushed
the
minimal-app
branch
from
78535ba to
1e5db2b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From giraffe-fsharp/Giraffe#497 (comment)