Refactor hhnet script to use networkctl #354
Conversation
|
@pau-hedgehog, I'm not arguing about whether it's more stable, but what kind of change do you see with that change? |
With this I stopped hitting #292 in env-3, which was blocking me completely (I will add the reference) But first I want to validate this more thoroughly in CI. In the meantime, please tell me if you prefer to set it as draft |
pkg/hhfab/hhnet.sh
Outdated
| done | ||
|
|
||
| sudo ip l s "$bond_name" up | ||
| sudo systemctl restart systemd-networkd 2> /dev/null || true |
There was a problem hiding this comment.
In theory, networkctl reload should reconfigure the network, but restart is probably more reliable
There was a problem hiding this comment.
I'm trying with this
| function cleanup() { | ||
| for i in {0..3}; do | ||
| sudo ip l d "bond$i" 2> /dev/null || true | ||
| sudo networkctl down "bond$i" 2> /dev/null || true |
There was a problem hiding this comment.
Do we even need to down bonds/interfaces/vlans? If we're removing the dropins and the restarting networkd it should do all the cleanup
There was a problem hiding this comment.
I think the cleanup will be more idempotent this way
|
@pau-hedgehog no, using networkd completely makes sense to me, I think it's an artifact from the very early stage when it was probably not even a flatcar but ubuntu on the test servers |
|
I think it may break the LLDP as only a first matching dropin will be used, so, you maybe need to enable LLDP on the slave interfaces, not sure |
good point. It's not working. I'll make sure the inspect passes |
Signed-off-by: Pau Capdevila <[email protected]>
Signed-off-by: Pau Capdevila <[email protected]>
Signed-off-by: Pau Capdevila <[email protected]>
Signed-off-by: Pau Capdevila <[email protected]>
Signed-off-by: Pau Capdevila <[email protected]>
pau-hedgehog
force-pushed
the
hhnet_refactor
branch
from
a0c2ff8 to
78c93d2
Compare
Signed-off-by: Pau Capdevila <[email protected]>
Signed-off-by: Pau Capdevila <[email protected]>
pau-hedgehog
force-pushed
the
hhnet_refactor
branch
from
9a833ed to
55b32f3
Compare
Signed-off-by: Pau Capdevila <[email protected]>
pau-hedgehog
force-pushed
the
hhnet_refactor
branch
from
55b32f3 to
0b9ea04
Compare
Migrate to networkctl for stability
Fixes #292