Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use an exact commit sha instead of a ref due to TOCTOU vulns #36

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

GrantBirki
Copy link
Member

@GrantBirki GrantBirki commented Dec 5, 2024

This pull request updates the branch-deploy workflow to use an exact commit SHA instead of a ref for added safety

Copy link

github-actions bot commented Dec 5, 2024

👋 Thanks for opening a pull request!

If you are new, please check out the trimmed down deployment summary listed below:

  1. ✔️ Obtain an approval/review on this pull request

  2. 🚀 Branch deploy your pull request to production with .deploy

    If anything goes wrong, rollback with .deploy main

  3. 🎉 Merge!

@GrantBirki
Copy link
Member Author

.deploy

Copy link

github-actions bot commented Dec 5, 2024

Deployment Triggered 🚀

GrantBirki, started a branch deployment to production

You can watch the progress here 🔗

Branch: sha-instead-of-ref

Copy link

github-actions bot commented Dec 5, 2024

Deployment Results ✅

GrantBirki successfully branch deployed branch sha-instead-of-ref to production

Show Results
====================================================================
Starting LDAP Container
Date: Thu Dec  5 21:11:32 UTC 2024, Environment: entitlements-config
====================================================================
9d3457e8240cc92e87cb057b781b7375506daa0e9175ee11c9288ae257b5b10f
====================================================================
Executing deploy-entitlements -c /home/runner/work/entitlements-config/entitlements-config/config/entitlements.yaml
Date: Thu Dec  5 21:11:47 UTC 2024, Environment: entitlements-config
====================================================================
/home/runner/work/entitlements-config/entitlements-config/vendor/bundle/ruby/3.3.0/gems/net-ldap-0.19.0/lib/net/ldap/password.rb:5: warning: base64 was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add base64 to your Gemfile or gemspec. Also contact author of net-ldap-0.19.0 to add base64 into its gemspec.
I, [2024-12-05T21:11:47.548520 #2479]  INFO -- : CHANGE cn=admin,ou=strictly-audited,ou=Entitlements,ou=Groups,dc=example,dc=org in entitlements/strictly-audited
I, [2024-12-05T21:11:47.548562 #2479]  INFO -- : .  - danhoerst
I, [2024-12-05T21:11:47.556827 #2479]  INFO -- : Successfully applied 1 change(s)!

@GrantBirki GrantBirki merged commit a0ae982 into main Dec 5, 2024
6 checks passed
@GrantBirki GrantBirki deleted the sha-instead-of-ref branch December 5, 2024 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants