Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/preview post #418

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

yurimutti
Copy link

@yurimutti yurimutti commented Nov 5, 2024

What kind of change does this PR introduce?

Created a post preview page

Why was this change needed?

Related #218

Other information:

I am open to discuss more about this feature

Checklist:

Put a "X" in the boxes below to indicate you have followed the checklist;

  • I have read the CONTRIBUTING guide.
  • I checked that there were not similar issues or PRs already open for this.
  • This PR fixes just ONE issue (do not include multiple issues or types of change in the same PR) For example, don't try and fix a UI issue and include new dependencies in the same PR.

https://www.loom.com/share/ef80c01856314528a1a79ba0be3d72d7?sid=ea1248bf-b1d7-46fe-b5a8-036b102b65a8

Copy link

vercel bot commented Nov 5, 2024

@yurimutti is attempting to deploy a commit to the Listinai Team on Vercel.

A member of the Team first needs to authorize it.

@@ -1,6 +1,7 @@
'use client';

import React, {
Component,

Check warning

Code scanning / ESLint

Disallow unused variables Warning

'Component' is defined but never used.
@@ -34,6 +35,9 @@
import { AddPostButton } from '@gitroom/frontend/components/launches/add.post.button';
import { GeneralPreviewComponent } from '@gitroom/frontend/components/launches/general.preview.component';
import { capitalize } from 'lodash';
import { date } from 'yup';

Check warning

Code scanning / ESLint

Disallow unused variables Warning

'date' is defined but never used.
@@ -88,6 +92,8 @@
hideMenu?: boolean;
show: boolean;
}) => {
const toast = useToaster();
const modal = useModals();

Check warning

Code scanning / ESLint

Disallow unused variables Warning

'modal' is assigned a value but never used.

const getPostsMarketplace = useCallback(async () => {
return (await fetch(`/posts/${id}`)).json();
}, [id]);

Check warning

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Warning

React Hook useCallback has a missing dependency: 'fetch'. Either include it or remove the dependency array.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant