onSnapshotReceived modelled after onMongoConnect #16

lerouxb · 2016-06-14T12:47:08Z

liveCollection.onSnapshotReceived()
  .then(function() {
    // liveCollection has now been initialised. Do whatever.
  });

suprememoocow · 2016-06-14T12:48:54Z

lib/live-collection.js

+    } else {
+      debug('Awaiting snapshot');
+      return new Promise(function(resolve) {
+        this.once('snapshot', function() {


this is unbound here

Damnit. Fixed.

suprememoocow · 2016-06-14T12:53:18Z

lib/live-collection.js

    this.trigger('sync');
    this.trigger('snapshot');
  },

+  onSnapshotReceived: function() {
+    if (this.snapshotReceived) {


This implementation currently doesn't take into account the collection being reset after a Bayeux reset.

Putting a _snapshotReceived = false on the first line of _resetOptional (before the short-curcuit) is probably the best place to put this.

suprememoocow · 2016-06-15T13:33:08Z

lib/live-collection.js

+          debug('Snapshot received');
+          resolve();
+        });
+        self.once('subscriptionError', function() {


You still need to forward the event from the templateSubscription. Maybe a test would help?

suprememoocow · 2016-06-20T13:56:06Z

lib/live-collection.js

+        });
+        self.once('error', function() {
+          debug('Error received before promise could get resolved.');
+          reject();


reject(err)

onSnapshotReceived modelled after onMongoConnect

67b02fa

lerouxb added the in progress label Jun 14, 2016

lerouxb assigned lerouxb and suprememoocow Jun 14, 2016

suprememoocow reviewed Jun 14, 2016
View reviewed changes

Le Roux Bodenstein added 2 commits June 14, 2016 14:51

Rename this.snapshotReceived to this._snapshotReceived

41efe83

Aargh this binding. How embarrasssing.

0bb478e

suprememoocow reviewed Jun 14, 2016
View reviewed changes

Le Roux Bodenstein added 3 commits June 14, 2016 14:58

Clear this._snapshotReceived during a bayeaux reset.

89ac261

Reject on subscription error.

d49461c

Import bluebird promise.

2e5a203

suprememoocow reviewed Jun 15, 2016
View reviewed changes

use forwarded event

5d15dc0

suprememoocow reviewed Jun 20, 2016
View reviewed changes

Pass the error on to reject()

5d07a0a

lerouxb removed the in progress label Jun 24, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

onSnapshotReceived modelled after onMongoConnect #16

onSnapshotReceived modelled after onMongoConnect #16

lerouxb commented Jun 14, 2016

suprememoocow Jun 14, 2016

lerouxb Jun 14, 2016

suprememoocow Jun 14, 2016 •

edited

Loading

suprememoocow Jun 15, 2016

suprememoocow Jun 20, 2016

onSnapshotReceived modelled after onMongoConnect #16

Are you sure you want to change the base?

onSnapshotReceived modelled after onMongoConnect #16

Conversation

lerouxb commented Jun 14, 2016

suprememoocow Jun 14, 2016

Choose a reason for hiding this comment

lerouxb Jun 14, 2016

Choose a reason for hiding this comment

suprememoocow Jun 14, 2016 • edited Loading

Choose a reason for hiding this comment

suprememoocow Jun 15, 2016

Choose a reason for hiding this comment

suprememoocow Jun 20, 2016

Choose a reason for hiding this comment

suprememoocow Jun 14, 2016 •

edited

Loading