Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add shiori #8

Merged
merged 2 commits into from
Aug 6, 2024
Merged

feat: add shiori #8

merged 2 commits into from
Aug 6, 2024

Conversation

christophenne
Copy link
Member

No description provided.

@christophenne
feat: add shiori
e645198 
Signed-off-by: christoph <[email protected]>
@christophenne christophenne requested a review from pmig August 6, 2024 00:23
pmig
pmig requested changes Aug 6, 2024
View reviewed changes
Copy link
Member

@pmig pmig left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the repo locally and it works. :-) 🎉

Great job.

I just added some small general deployment best practice comments.

P.s.: I made the changes out of my mind, please validate and test them ;-)

apps/shiori/deployment.yaml Outdated Show resolved Hide resolved
apps/shiori/ingress.yaml Outdated Show resolved Hide resolved
apps/shiori/deployment.yaml Show resolved Hide resolved
apps/shiori/service.yaml Outdated Show resolved Hide resolved
packages/cloudnative-pg/clusterpackage.yaml Outdated Show resolved Hide resolved
apps/shiori/namespace.yaml Outdated Show resolved Hide resolved
apps/shiori/ingress.yaml Outdated Show resolved Hide resolved
apps/shiori/deployment.yaml Outdated Show resolved Hide resolved
@christophenne christophenne requested a review from pmig August 6, 2024 16:50
@pmig pmig merged commit c67d3b0 into main Aug 6, 2024
@pmig pmig deleted the christoph/starter branch August 8, 2024 03:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmig pmig pmig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@christophenne @pmig