Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #239 by updating the definition #279

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Fix #239 by updating the definition #279

merged 2 commits into from
Mar 31, 2020

Conversation

jmccrae
Copy link
Member

@jmccrae jmccrae commented Jan 31, 2020 •
edited
Loading

Fix #239

@jmccrae jmccrae requested a review from arademaker January 31, 2020 12:14
@arademaker
Copy link
Member

Related to #239

arademaker
arademaker approved these changes Mar 16, 2020
View reviewed changes
Copy link
Member

@arademaker arademaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine to me. But in the #239 @jmccrae said

I wouldn't want to change it just make the definitions more explicit.

So we are postponing the discussion between the difference between the verbal sense of state and the adjective sense also related to a state.

@jmccrae jmccrae merged commit 727a478 into master Mar 31, 2020
@jmccrae jmccrae deleted the issue-239 branch March 31, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arademaker arademaker arademaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sit (definition)
2 participants
@jmccrae @arademaker