Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 通知をタップした時にアプリに復帰する処理が動いていなかった #13

Merged
merged 1 commit into from
Dec 15, 2023
Merged

fix: 通知をタップした時にアプリに復帰する処理が動いていなかった #13

merged 1 commit into from
Dec 15, 2023

Conversation

koutaro-masaki
Copy link

通知をタップした時のイベントに登録すべきイベントが誤っていて、アプリへの復帰が実行されていなかった

Android 10

Android 13

shnjp
shnjp approved these changes Dec 15, 2023
View reviewed changes
Copy link
Member

@shnjp shnjp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

何なのか全く分かってないけどApprove推してる

@koutaro-masaki koutaro-masaki merged commit 5bb58fc into glucose-hosted Dec 15, 2023
1 check passed
@koutaro-masaki koutaro-masaki deleted the fix/android-tap-notification branch December 15, 2023 05:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryo0511 ryo0511 ryo0511 approved these changes

@shnjp shnjp shnjp approved these changes

@tomoya-hori tomoya-hori Awaiting requested review from tomoya-hori

Assignees
No one assigned
Labels
p: video_player platform-android
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@koutaro-masaki @shnjp @ryo0511