fix: Prevents CTRL+P from being masked by a given accelerator defined in FXML (#553) #593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in FXML. Hence allowing to show preview with CTRL+P.
Closed
app/src/main/java/com/oracle/javafx/scenebuilder/app/DocumentWindowController.java
Outdated
Show resolved
Hide resolved
Oliver-Loeffler
changed the title
jperedadnr
approved these changes
Oct 30, 2024
There was a problem hiding this comment.
This looks good. I've tested with an FXML file that has the accelerator on Mac (but it didn't happen) and Windows (failed before this PR, passes after it).
I wonder why the accelerator from the FXML gets installed and somehow takes precedence, but your fix won't hurt in any case.
abhinayagarwal
approved these changes
Oct 31, 2024
|
I actually have to admit, that this behavior also irritated me. However, it seems to be confusing. I'm updating this branch to see if it still works after all those recent changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This quick fix will prevent
CTRL+Pfrom being blocked by a accelerator defined in an FXML.CTRL+Pis used to display the preview window and it works with some FXMLs, not with others.A clean solution to this requires lot more work. With the current way the Scene Builder works, the problem can occurr with any other accelerator defined in Scene Builder.
Issue
Fixes #553
Progress