-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkins jobs which are not required for release branch #48
base: main
Are you sure you want to change the base?
Conversation
The list is similar to what we run on gerrit.
So, as discussed on IRC, I would need a better answer than "we did it before". I think that given that's a different codebase, we need to verify it build like on devel. |
Hello. Are we taking this PR in? Both fedora-smoke and python compliance are failing for PRs against release branches |
Only the fedora-smoke is disabled for release-N branches. Do you see any new failure? |
Yes for gluster/glusterfs#1561, both smoke and python compliance failed. |
gluster/glusterfs#1562 too.. |
So python-compliance failed 4 days ago if you check the jenkins job details. It is also not required to pass for merge. So we are good with python-compliance. fedora-smoke is also not running for recent triggers on PR #1562, it did fail before and is a part of branch protection rule. So your PR stucked there. I'm looking for a way of how to get away with fedora-smoke failure on this PR. I don't want to change the setting as a whole for the branch protection rule. |
Ah okay got it. |
But so, why are we blocking the test on release ? I get that it fail on current release for some test, but I think that this should be restricted on those tests and those release. For example, if freebsd-smoke is fine, then it should be run on release branch as well. If release-X is fine but not X-1, then we shouldn't use '*'. |
The list is similar to what we run on gerrit. Let me know if there is any other job to be included.