Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Building with uncommitted changes on MacOS and Windows #17

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

warrenalphonso
Copy link

Description

aab build dev wasn't working for me on MacOS, because the command being executed to get timestamps of uncommitted changes was different. The original code had a link to this StackOverflow post, which conveniently lists the code that needs to be run on Linux, MacOS, and Windows to get timestamps. All this PR does is check for the user's OS, and run the appropriate command. This fixed the command for me on MacOS. I don't have access to a Windows computer, so I haven't tested it on there.

Aside from that simple change, I also had to use a regex to extract the digits in the timestamp out from the entire command output. I'm not sure why this wasn't necessary before, so if this breaks something for someone else, please let me know. From my tests, though, the commands from the StackOverflow post print output in the form M 1618523117 designer/options.ui, so to convert it to an integer we'd have to pick out the part of the string that was an integer.

Checklist:

Please replace the space inside the brackets with an x and fill out the ellipses if the following items apply:

@BlueGreenMagick BlueGreenMagick mentioned this pull request Apr 9, 2022
3 tasks
@glutanimate glutanimate self-requested a review May 15, 2022 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant