Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSUB-861, CSUB-883: Example for migrations and their tests #120

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

CSUB-861, CSUB-883: Example for migrations and their tests #120

wants to merge 10 commits into from

Conversation

atodorov
Copy link
Contributor

@atodorov atodorov commented Dec 7, 2023

Description of proposed changes

Practical tips for PR review & merge:

  • All GitHub Actions report PASS
  • Newly added code/functions have unit tests
    • Coverage tools report all newly added lines as covered
    • The positive scenario is exercised
    • Negative scenarios are exercised, e.g. assert on all possible errors
    • Assert on events triggered if applicable
    • Assert on changes made to storage if applicable
  • Modified behavior/functions - try to make sure above test items are covered
  • Integration tests are added if applicable/needed

atodorov and others added 10 commits December 6, 2023 21:41
@atodorov
Rename pallets/bridge to pallet-bridge
6f8f6a1 
for consistency with other pallets and future test scripts which will be
added as part of #106.
@atodorov
Auto-update TypeScript type definitions
891d1d0
@atodorov
Add empty migration in order to test out everything else around it
4c7beff 
also add rudimentary mock runtime so that unit test for migrations can
execute
@atodorov
Actually migrate pallet-bridge storage items
faf8959 
Substrate/Polkadot pallet prefix migration example:
paritytech/substrate#9115

NOTE: migration weight is based on the number of items in storage
@atodorov
Return maximum weight when using move_pallet()
a78d9e1 
inspired by paritytech/substrate#9115

NOTE: also makes assertion in unit tests easier
@atodorov
Allow unused_imports for KeyPrefixIterator
7a00d35 
which is used as part of pre_upgrade()/post_upgrade() which will be
enabled when adding the `try-runtime` feature later on.
@atodorov
Bump version to 3.9.1
1f934d5
@atodorov
Revert "Return maximum weight when using move_pallet()"
1aca9d5 
This reverts commit a78d9e1.
@atodorov
WIP: Attempt at setting up old storage items before migration tests
b379a3e 
WARNING: adds an assert inside v1::migrate() which should be removed!
@atodorov
Assert on new pallet name
88a5170
@atodorov atodorov force-pushed the testing-for-improvement/CSUB-883-rename-pallet-bridge branch from c96b6ca to 88a5170 Compare December 7, 2023 16:38
@atodorov atodorov changed the title CSUB-883: Try adding data in storage with old pallet name so we can test migrations better CSUB-861, CSUB-883: Try adding data in storage with old pallet name so we can test migrations better Dec 8, 2023
@atodorov atodorov changed the title CSUB-861, CSUB-883: Try adding data in storage with old pallet name so we can test migrations better CSUB-861, CSUB-883: Example for migrations and their tests Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@atodorov