Fix Subscan URL #14
Open
Fix Subscan URL #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How does this fix the URL? Is it only showing incorrectly in the report? |
Yes. |
|
Similar question to pablo. I have little insight into what is broken/being fixed |
|
Just fixing the subscan url in the report. |
atodorov
reviewed
Mar 18, 2024
| @@ -267,7 +267,7 @@ impl From<RawData> for Report { | |||
| report.add_raw_text(format!( | |||
| "{} <b><a href=\"https://{}.subscan.io/validator/{}\">{}</a></b>", | |||
| is_active_desc, | |||
| data.network.name.to_lowercase().trim().replace(" ", ""), | |||
| data.network.name.to_lowercase().trim().replace(" ", "-"), | |||
There was a problem hiding this comment.
The immediate patch looks good to me, hoever all of this looks very fragile.
If the name becomes "Creditcoin 3" then the URL will be incorrect again.
Q: where does the name come from? Is if hard-coded somewhere in the source code?
atodorov
requested changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.