bugfix: Arithmetic operation overflowstack (#26)

gnosis · May 24, 2024 · 6924224 · 6924224
1 parent ca55c3c
commit 6924224
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/src/domain/dex/mod.rs b/src/domain/dex/mod.rs
@@ -146,7 +146,8 @@ impl Swap {
     }
 
     pub fn satisfies(&self, order: &domain::order::Order) -> bool {
-        self.output.amount * order.sell.amount >= self.input.amount * order.buy.amount
+        self.output.amount.full_mul(order.sell.amount)
+            >= self.input.amount.full_mul(order.buy.amount)
     }
 }
 

diff --git a/src/tests/zeroex/out_of_price.rs b/src/tests/zeroex/out_of_price.rs
@@ -109,7 +109,7 @@ async fn sell() {
                     "buyToken": "0xe41d2489571d322189246dafa5ebde1f4699f498",
                     "sellAmount": "1000000000000000000",
                     // Way too much...
-                    "buyAmount": "1000000000000000000000000000000000000",
+                    "buyAmount": "30014022222222222222222222222222222222222222222199033052181473140736",
                     "fullSellAmount": "1000000000000000000",
                     "fullBuyAmount": "1000000000000000000000000000000000000",
                     "kind": "sell",