Feature - refactor framework core to php82 #493

lisachenko · 2024-04-01T16:15:27Z

This PR changes internal Aop/Framework and Aop/Intercept to use PHP8.2 features and phpstan level 9 checks to ensure that codebase is stable and don't contain known logic errors.

…vel 9 checks

scrutinizer-notifier · 2024-04-01T16:15:35Z

A new inspection was created.

Nitpick-CI · 2024-04-01T16:16:25Z

src/Aop/Framework/AbstractInterceptor.php

-        $this->pointcutExpression = $pointcutExpression;
-    }
+    public function __construct(
+        protected readonly Closure $adviceMethod,


Line indented incorrectly; expected 4 spaces, found 8

Nitpick-CI · 2024-04-01T16:16:26Z

src/Aop/Framework/AbstractInterceptor.php

-    }
+    public function __construct(
+        protected readonly Closure $adviceMethod,
+        private readonly int $adviceOrder = 0,


Line indented incorrectly; expected 4 spaces, found 8

Nitpick-CI · 2024-04-01T16:16:26Z

src/Aop/Framework/AbstractInterceptor.php

+    public function __construct(
+        protected readonly Closure $adviceMethod,
+        private readonly int $adviceOrder = 0,
+        protected readonly string $pointcutExpression = ''


Line indented incorrectly; expected 4 spaces, found 8

Nitpick-CI · 2024-04-01T16:16:27Z

src/Aop/Framework/AbstractInterceptor.php

+        protected readonly Closure $adviceMethod,
+        private readonly int $adviceOrder = 0,
+        protected readonly string $pointcutExpression = ''
+    ) {}


Closing brace must be on a line by itself

Nitpick-CI · 2024-04-01T16:16:28Z

src/Aop/Framework/AbstractJoinpoint.php

-    {
-        $this->advices = $advices;
-    }
+    public function __construct(protected readonly array $advices = []) {}


Line indented incorrectly; expected 0 spaces, found 4

Opening brace should be on a new line

Closing brace must be on a line by itself

Nitpick-CI · 2024-04-01T16:16:29Z

src/Aop/Framework/AbstractJoinpoint.php

-                    default:
-                        return 0;
-                }
+            fn(Advice $first, Advice $second) => match (true) {


Space before opening parenthesis of function call prohibited

Nitpick-CI · 2024-04-01T16:16:30Z

src/Aop/Framework/AbstractJoinpoint.php

-                        return 0;
-                }
+            fn(Advice $first, Advice $second) => match (true) {
+                $first instanceof AdviceBefore && !($second instanceof AdviceBefore) => -1,


Multi-line function call not indented correctly; expected 12 spaces but found 16

Nitpick-CI · 2024-04-01T16:16:31Z

src/Aop/Framework/AbstractJoinpoint.php

-                }
+            fn(Advice $first, Advice $second) => match (true) {
+                $first instanceof AdviceBefore && !($second instanceof AdviceBefore) => -1,
+                $first instanceof AdviceAround && !($second instanceof AdviceAround) => 1,


Multi-line function call not indented correctly; expected 12 spaces but found 16

Nitpick-CI · 2024-04-01T16:16:31Z

src/Aop/Framework/AbstractJoinpoint.php

+            fn(Advice $first, Advice $second) => match (true) {
+                $first instanceof AdviceBefore && !($second instanceof AdviceBefore) => -1,
+                $first instanceof AdviceAround && !($second instanceof AdviceAround) => 1,
+                $first instanceof AdviceAfter && !($second instanceof AdviceAfter) => $second instanceof AdviceBefore ? 1 : -1,


Multi-line function call not indented correctly; expected 12 spaces but found 16

Nitpick-CI · 2024-04-01T16:16:32Z

src/Aop/Framework/AbstractJoinpoint.php

+                $first instanceof AdviceBefore && !($second instanceof AdviceBefore) => -1,
+                $first instanceof AdviceAround && !($second instanceof AdviceAround) => 1,
+                $first instanceof AdviceAfter && !($second instanceof AdviceAfter) => $second instanceof AdviceBefore ? 1 : -1,
+                $first instanceof OrderedAdvice && $second instanceof OrderedAdvice => $first->getAdviceOrder() - $second->getAdviceOrder(),


Multi-line function call not indented correctly; expected 12 spaces but found 16

Nitpick-CI · 2024-04-01T16:16:33Z

src/Aop/Framework/AbstractJoinpoint.php

+                $first instanceof AdviceAround && !($second instanceof AdviceAround) => 1,
+                $first instanceof AdviceAfter && !($second instanceof AdviceAfter) => $second instanceof AdviceBefore ? 1 : -1,
+                $first instanceof OrderedAdvice && $second instanceof OrderedAdvice => $first->getAdviceOrder() - $second->getAdviceOrder(),
+                default => 0,


Multi-line function call not indented correctly; expected 12 spaces but found 16

Line indented incorrectly; expected 4 spaces, found 16

Nitpick-CI · 2024-04-01T16:16:33Z

src/Aop/Framework/DeclareErrorInterceptor.php

-        $this->message = $message;
-        $this->level   = $errorLevel;
+    public function __construct(
+        protected string $message,


Line indented incorrectly; expected 4 spaces, found 8

Nitpick-CI · 2024-04-01T16:16:34Z

src/Aop/Framework/DeclareErrorInterceptor.php

-        $this->level   = $errorLevel;
+    public function __construct(
+        protected string $message,
+        protected int $level,


Line indented incorrectly; expected 4 spaces, found 8

Nitpick-CI · 2024-04-01T16:16:35Z

src/Aop/Framework/DynamicInvocationMatcherInterceptor.php

-        $this->interceptor = $interceptor;
-    }
+    public function __construct(
+        private PointFilter $pointFilter,


Line indented incorrectly; expected 4 spaces, found 8

Nitpick-CI · 2024-04-01T16:16:35Z

src/Aop/Framework/DynamicInvocationMatcherInterceptor.php

-    }
+    public function __construct(
+        private PointFilter $pointFilter,
+        private Interceptor $interceptor


Line indented incorrectly; expected 4 spaces, found 8

Nitpick-CI · 2024-04-01T16:16:36Z

src/Aop/Framework/DynamicInvocationMatcherInterceptor.php

+    public function __construct(
+        private PointFilter $pointFilter,
+        private Interceptor $interceptor
+    ){}


There must be a single space between the closing parenthesis and the opening brace of a multi-line function declaration; found 0 spaces

Closing brace must be on a line by itself

Nitpick-CI · 2024-04-01T16:16:37Z

src/Aop/Framework/TraitIntroductionInfo.php

-        $this->introducedInterface = $introducedInterface;
-    }
+    public function __construct(
+        private string $introducedTrait,


Line indented incorrectly; expected 4 spaces, found 8

Nitpick-CI · 2024-04-01T16:16:38Z

src/Aop/Framework/TraitIntroductionInfo.php

-    }
+    public function __construct(
+        private string $introducedTrait,
+        private string $introducedInterface


Line indented incorrectly; expected 4 spaces, found 8

Nitpick-CI · 2024-04-01T16:16:38Z

src/Aop/Framework/TraitIntroductionInfo.php

+    public function __construct(
+        private string $introducedTrait,
+        private string $introducedInterface
+    ){}


There must be a single space between the closing parenthesis and the opening brace of a multi-line function declaration; found 0 spaces

Closing brace must be on a line by itself

Nitpick-CI · 2024-04-01T16:16:39Z

src/Aop/Intercept/FieldAccessType.php

+    /**
+     * The read access type
+     */
+    case READ = 'get';


Line indented incorrectly; expected 0 spaces, found 4

Nitpick-CI · 2024-04-01T16:16:40Z

src/Aop/Intercept/FieldAccessType.php

+    /**
+     * The write access type
+     */
+    case WRITE = 'set';


Line indented incorrectly; expected 0 spaces, found 4

Nitpick-CI · 2024-04-01T16:16:40Z

src/Aop/Intercept/FieldAccessType.php

+     * The write access type
+     */
+    case WRITE = 'set';
+}


Line indented incorrectly; expected at least 4 spaces, found 0

lisachenko added 2 commits March 31, 2024 22:17

[BC Break] Convert FieldAccess constants into the FieldAccessType enum

72ce6a0

[BC Break] Refactor framework core for PHP8.2 features and phpstan le…

4117b7d

…vel 9 checks

lisachenko added BC Break PHP-8.2 labels Apr 1, 2024

Nitpick-CI reviewed Apr 1, 2024

View reviewed changes

lisachenko merged commit a0930b2 into master Apr 1, 2024
6 checks passed

lisachenko deleted the feature/refactor-core-to-php82 branch April 1, 2024 20:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature - refactor framework core to php82 #493

Feature - refactor framework core to php82 #493

lisachenko commented Apr 1, 2024

scrutinizer-notifier commented Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Nitpick-CI Apr 1, 2024

Feature - refactor framework core to php82 #493

Feature - refactor framework core to php82 #493

Conversation

lisachenko commented Apr 1, 2024

scrutinizer-notifier commented Apr 1, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment