[BC Break] Internal container refactoring. #501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New version drops GoAspectContainer class and rely just on Container class now. Container uses now generic methods, so IDE and PhpStan aware about types now. Tags have been replaced with interface names, which simplifies usage of marker interfaces. All unnecessary string variables were replaced with class FQN. No more special methods to register advisors or pointcuts - they are just values in container.
|
A new inspection was created. |
Nitpick-CI
reviewed
Apr 14, 2024
| { | ||
| $this->loaders[] = $loader; | ||
| public function __construct( | ||
| protected AspectContainer $container, |
There was a problem hiding this comment.
Line indented incorrectly; expected 4 spaces, found 8
Nitpick-CI
reviewed
Apr 14, 2024
| @@ -83,7 +80,7 @@ protected function getAdvice( | |||
| $interceptorAttribute instanceof After => new AfterInterceptor($adviceCallback, $adviceOrder, $pointcutExpression), | |||
| $interceptorAttribute instanceof Around => new AroundInterceptor($adviceCallback, $adviceOrder, $pointcutExpression), | |||
| $interceptorAttribute instanceof AfterThrowing => new AfterThrowingInterceptor($adviceCallback, $adviceOrder, $pointcutExpression), | |||
| default => throw new UnexpectedValueException('Unsupported method meta class: ' . get_class($interceptorAttribute)), | |||
| default => throw new UnexpectedValueException('Unsupported method meta class: ' . $interceptorAttribute::class), | |||
There was a problem hiding this comment.
Line indented incorrectly; expected 8 spaces, found 12
Nitpick-CI
reviewed
Apr 14, 2024
| $result[$id] = $this->get($id); | ||
| } | ||
| } | ||
| $this->add($id, function (self $container) use ($id, $lazyDefinitionClosure): object { |
There was a problem hiding this comment.
Expected 1 space after closing parenthesis; found 0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New version drops the
GoAspectContainerclass and rely just on Container class now.Container uses now generic methods, so IDE and PhpStan aware about types now.
Tags have been replaced with interface names, which simplifies usage of marker interfaces.
All unnecessary string variables were replaced with class FQN.
No more special methods to register advisors or pointcuts - they are just values in container.