-
-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Step 2 Upgrade] Bump requirement to php 8.0 #125
Conversation
…ctionClassLikeTrait
@samsonasik There might be good parts which can be cherry-picked from the #122 or #121 - both of them were not merged. |
I will check 👍 |
… to support original ReflectionParameter::__toString()
The current skipped @lisachenko Ready to merge 👍 |
Awesome work! 👍 Let me check this today in the evening ) |
Question here: do you plant to add PHP8 Attributes as separate independent PR? |
If you mean Otherwise, I may need failing test case for that to be implemented. |
The inspection completed: No new issues |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, thanks
@lisachenko here the 2nd step 👍 , bump to php 8.0