Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Step 5 Upgrade] Bump requirement to php 8.2 #128

Merged
merged 2 commits into from
Jan 23, 2024
Merged

[Step 5 Upgrade] Bump requirement to php 8.2 #128

merged 2 commits into from
Jan 23, 2024

Conversation

samsonasik
Copy link
Contributor

@lisachenko here the 5th step 👍 , bump to php 8.2

@samsonasik samsonasik requested a review from lisachenko January 21, 2024 01:26
@samsonasik
Copy link
Contributor Author

implemented 🎉 @lisachenko Ready to merge 👍

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@samsonasik
Copy link
Contributor Author

@lisachenko it is ready to merge 👍

@TomasVotruba
Copy link

Seems good to go 👍

@lisachenko
Copy link
Member

Here we go! 🕺

@lisachenko
Copy link
Member

Btw, do you know where this annoying travis-ci check comes from? I've checked every tab, removed travis-ci from everywhere, but still this check is here...

@lisachenko lisachenko merged commit b8e46fa into goaop:master Jan 23, 2024
2 checks passed
@lisachenko
Copy link
Member

Congrats, @samsonasik!

The only missing final part here, for parser-reflection now is ReflectionAttribute + relevant attributes API, which can be ported from https://github.com/goaop/parser-reflection/pull/122/files#diff-538c6d3a73a6c88b7717c7483cefab2a2f7c9ff32c5267a96ed2d6cbaaccc0d3

@samsonasik samsonasik deleted the step5-php82 branch January 23, 2024 10:11
@samsonasik
Copy link
Contributor Author

@lisachenko thank you for merging, I will look into the attribute part. I don't know about travis CI part as I don't have admin access on this repo, probably activated in API request somewhere in /settings/installations settings/hooks need to be disabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lisachenko lisachenko lisachenko approved these changes

Assignees
No one assigned
Labels
PHP8.2
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@samsonasik @scrutinizer-notifier @TomasVotruba @lisachenko