Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distance 1.1.3.1 #4888

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

PunishedPineapple
Copy link
Contributor

  • Updated for Dalamud API 11 and .net 9.
  • Please note that arcs (both boss aggro and custom) are not currently being drawn on-screen. Please do not submit feedback about this known issue. The Dalamud API function for converting world coordinates to screen coordinates is behaving differently than before patch 7.1. Depending on whether that is intentional, a future plugin update may be required to address this once the dust has settled. You can still enable the boss aggro distance text widget if desired.

@bleatbot bleatbot enabled auto-merge (squash) November 17, 2024 03:12
@bleatbot
Copy link
Collaborator

Builds failed, please check action output.

Take care! Please test your plugins in-game before submitting them here to prevent crashes and instability. We really appreciate it!

The average merge time for plugin updates is currently 2 hours.

Name Commit Status
😰 Distance [stable] 9b73eb9 Build system error: Specified argument was out of the range of valid values. (Parameter 'Unknown runtime requested: [net9.0-windows7.0, System.Collections.Generic.Dictionary`2[System.String,Plogon.NugetLockfile+Dependency]]')
Show log - Review

@bleatbot bleatbot added the build failed This plugin failed to build. label Nov 17, 2024
@MidoriKami
Copy link
Contributor

net9 is delayed for a lil bit, API11 is net8 still

@PunishedPineapple
Copy link
Contributor Author

Understood. I will roll back then.

@Infiziert90
Copy link
Contributor

The World to Screen function should work just fine, i use them in my plugins and also tested them in PixelPerfect today ... maybe because you had it set to net9 branch which was not the latest CS version? Would definitely recommend retesting with net8/stg branch

@PunishedPineapple PunishedPineapple marked this pull request as draft November 17, 2024 03:27
auto-merge was automatically disabled November 17, 2024 03:27

Pull request was converted to draft

@PunishedPineapple
Copy link
Contributor Author

PunishedPineapple commented Nov 17, 2024

Dalamud isn't updating for me when set to stg, so I assumed net9 was what was getting used based on what was said in the discussion post on the Dalamud repo earlier this week. I'm just going to draft this until Dalamud is updated for the masses. I don't play anymore and am just too tired to try to figure out why I'm not getting stg. Sorry for the trouble.

@reiichi001
Copy link
Contributor

It's likely the beta key/kind. Both have to be set in your dalamud config. (Public testing hasn't started just yet, so the only place that's been announced is in the private dev channels. Feel free to DM me on Discord though and I can sort that out for you if you want)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failed This plugin failed to build.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants