Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused function #453

Open
wants to merge 4 commits into
base: latest
Choose a base branch
from

Conversation

Brijeshthummar02
Copy link

issue #446

Copy link

codecov bot commented Sep 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.36%. Comparing base (72f40f9) to head (e09062d).

Additional details and impacted files
@@            Coverage Diff             @@
##           latest     #453      +/-   ##
==========================================
- Coverage   90.48%   90.36%   -0.13%     
==========================================
  Files          47       46       -1     
  Lines        4373     4129     -244     
  Branches      585      579       -6     
==========================================
- Hits         3957     3731     -226     
+ Misses        281      266      -15     
+ Partials      135      132       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@goatshriek goatshriek self-assigned this Sep 29, 2024
Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add an entry for tolower in tools/check_headers/c_standard_library.yml to resolve the missing header error.

@Brijeshthummar02
Copy link
Author

@goatshriek any furthur changes?

Copy link
Owner

@goatshriek goatshriek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's been long enough for the CI logs to have aged off, so I can't review what the last failure was from. Please remove the unrelated changes from the PR and the tests will re-run on the updated pull.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes seem to be related to a different change - please take them out of this branch so that they can be merged in separate commits.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants