Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(BIDS-2531) add filter for online/offline, fix all count #2638

Merged
merged 3 commits into from
Nov 2, 2023

Conversation

gocoffeecup
Copy link
Contributor

@gocoffeecup gocoffeecup commented Oct 24, 2023

🤖 Generated by Copilot at ef36a11

This pull request adds the ability to filter and view validators by their online or offline status on the web interface and the API. It modifies the templates/validators.html file and the parseValidatorsDataQueryParams function in the handlers/validators.go file.

Copy link
Collaborator

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typo needs to be fixed otherwise looking good.

templates/validators.html Outdated Show resolved Hide resolved
Copy link
Collaborator

@Eisei24 Eisei24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@D13ce D13ce merged commit fda1881 into gobitfly:master Nov 2, 2023
3 checks passed
D13ce added a commit that referenced this pull request Nov 2, 2023
@D13ce
Copy link
Contributor

D13ce commented Nov 2, 2023

Please ignore the "Revert" commit 😦

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants