(BIDS-2669) api: fix ordering of result of /api/v1/validator/leaderboard #2690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisei24
reviewed
Nov 13, 2023
There was a problem hiding this comment.
This fixes the bug with the reverse order but I noticed that the rank is not consistent.
Here is an example from Prater:
- On
/validators/leaderboardthe last rank is 606106 which is for validatorindex 318888 - When opening the validator
/validator/318888it has rank 606091 - The API also gives rank 606091 for that validator but also has other validators for the lower ranks up to 606106 (which would be validatorindex 602078 right now)
Is this a known issue?
this is because the leaderboard only gets updated once every day (every 225 epochs) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤖 Generated by Copilot at ed84339
Fixed a bug in the
ApiValidatorLeaderboardfunction that returned the wrong order of validators. Updated the SQL query inhandlers/api.goto sort by rank7d in ascending order.