Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(NOBIDS) Update the readme for local deployment #2752

Merged
merged 6 commits into from
Dec 11, 2023

Conversation

thib-wien
Copy link
Contributor

@thib-wien thib-wien commented Dec 5, 2023

Update the local-deployment Readme because some things are outdated or are mysterious to beginners.

🤖[deprecated] Generated by Copilot at be73127

This pull request enhances the local-deployment/README.md file with more detailed and updated instructions, links, and error handling for setting up and running the eth2-beaconchain-explorer locally. It also adjusts some code blocks and docker commands for clarity and consistency.

…o not work anymore or are mysterious to beginners
@thib-wien thib-wien requested a review from D13ce December 5, 2023 11:41
@thib-wien thib-wien changed the title (NOBIDS) Update the readme for local deployment because some things d… (NOBIDS) Update the readme for local deployment Dec 5, 2023
local-deployment/README.md Outdated Show resolved Hide resolved
local-deployment/README.md Outdated Show resolved Hide resolved
local-deployment/README.md Outdated Show resolved Hide resolved
local-deployment/README.md Outdated Show resolved Hide resolved
@thib-wien
Copy link
Contributor Author

thib-wien commented Dec 6, 2023

Dear @D13ce ,

I integrated your modifications and then I did a commit to take my replies into account.

You can see what I did after you here.
The reasons (my replies) are here and here

Was denkst du?

Copy link
Contributor

@D13ce D13ce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@thib-wien thib-wien merged commit 03e6687 into master Dec 11, 2023
3 checks passed
@thib-wien thib-wien deleted the NOBIDS/ClarifyAndUpdateReadmeForLocalDeployment branch December 11, 2023 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants