Exclude multithreaded main-main races by threadflag #1589
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a bit silly but the threadflag analysis
may_race
did not excludemain
-main
races even though it has all the information to do so.It almost never makes a difference because threadflag answers the
MustBeUniqueThread
query based on its flag still, and the threadid analysis uses that information in itsmay_race
.The more notable thing is the unexpected cram test (change). Usually accesses while single-threaded aren't even added to
allglobs
, but apparently the thread ID variable write inpthread_create
is added although as if single-threaded. This is odd for two reasons:allglobs
.This was always in the cram test but went unnoticed until I played around with this.