Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Await gasket.isReady to allow async configurations to be prepared #1035

Merged
merged 4 commits into from
Feb 21, 2025

Conversation

agerard-godaddy
Copy link
Contributor

@agerard-godaddy agerard-godaddy commented Feb 20, 2025

Summary

Await gasket.isReady to allow async configurations to be prepared

Changelog

@gasket/plugin-nextjs

  • Await gasket.isReady to allow async configurations to be prepared

Test Plan

Updated unit tests

@agerard-godaddy agerard-godaddy requested a review from a team as a code owner February 20, 2025 19:25
@sarya-godaddy
Copy link

sarya-godaddy commented Feb 20, 2025

the docs seem outdated since startServer awaits isReady https://github.com/godaddy/gasket/blob/main/packages/gasket-plugin-dynamic-plugins/README.md?plain=1#L37 and with this change the recommendation is to await isReady in actions called early in the app

@mmason2-godaddy mmason2-godaddy self-requested a review February 20, 2025 20:51
@agerard-godaddy
Copy link
Contributor Author

the docs seem outdated since startServer awaits isReady https://github.com/godaddy/gasket/blob/main/packages/gasket-plugin-dynamic-plugins/README.md?plain=1#L37 and with this change the recommendation is to await isReady in actions called early in the app

Good eye - I've updated that readme

@sarya-godaddy
Copy link

the docs seem outdated since startServer awaits isReady https://github.com/godaddy/gasket/blob/main/packages/gasket-plugin-dynamic-plugins/README.md?plain=1#L37 and with this change the recommendation is to await isReady in actions called early in the app

Good eye - I've updated that readme

also in the core readme

gasket.isReady.then(() => {

@agerard-godaddy agerard-godaddy merged commit a83966f into main Feb 21, 2025
2 checks passed
@agerard-godaddy agerard-godaddy deleted the await-prepare branch February 21, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants