feat: support pnpm package manager #645
Conversation
|
@sarya-godaddy Are you still actively working on this PR? The subject of |
|
@mmason2-godaddy Yes I can pick this back up. Just need to update the command line output and unit tests. I will get this ready for review by end of next week 03/01. gdcorp-action-public-forks/pnpm-action-setup is now also available for using pnpm in GHA |
| // Support for the .npmrc configured via --npmconfig flag. | ||
| // pnpm does not have a "userconfig" CLI flag, it does however still | ||
| // support the npm_config_* environment variables for npm compatibility. | ||
| if (this.npmconfig) env.NPM_CONFIG_USERCONFIG = this.npmconfig; |
There was a problem hiding this comment.
The --npmconfig flag is being removed in the next major version. See #647
While this is not a breaking change, if there's no immediate need for it now, could we just save pnpm support for our next major version 7?
There was a problem hiding this comment.
I don't see a need for it. people can migrate from npm to pnpm pretty easily. I will create another PR after new gasket-cli changes are merged
sarya-godaddy
requested review from
3rd-Eden,
Swaagie and
salilagrawal
as code owners
|
there is a PR for releasing this to v7 #797 |
Summary
Changelog
gasket createTest Plan