[PFX-491] - Set version for mermaid and docsify for gasket.dev #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agerard-godaddy
approved these changes
Jan 23, 2024
jpina1-godaddy
approved these changes
Jan 23, 2024
agerard-godaddy
pushed a commit
that referenced
this pull request
Jan 24, 2024
(cherry picked from commit e150bef)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bug reported that the lifecycle flow chart was busted on the gasket.dev site. Discovered this was related to a change in the mermaid API for newer versions that updated
mermaid.render()to return a promise, which was causing issues with Docsify. To fix this, we set mermaid version to the version just before this change.Also, took the opportunity to set the version of Docsify that gasket.dev is using.
Changelog
Set version for mermaid and docsify for gasket.dev.
Test Plan
Tested locally.