[PFX-454] - fix broken jest tests in @godaddy/webapp apps #678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agerard-godaddy
requested changes
Feb 16, 2024
This comment was marked as outdated.
This comment was marked as outdated.
mmason2-godaddy
requested review from
kbader-godaddy,
jpina1-godaddy and
bbetts-godaddy
agerard-godaddy
approved these changes
Feb 20, 2024
kbader-godaddy
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
First Error
Error: Jest could not parse the
cssimports and the@ux/pivot/styleimport correctly.Fix: moduleNameMapper to parse imports correctly. Stubbed file here
Second Error
Error:
[React Intl] Could not find requiredintlobject. <IntlProvider> needs to exist in the component ancestry.For whatever reasonreact-intlwasn't working properly.Fix: Mock
react-intlThird Error(Original error)
Error:
Error: Not implemented: window.computedStyle(elt, pseudoElt)Fix: Work around for this noisy error found via this GH comment
Changelog
Test Plan
New apps using
@godaddy/webapppreset SHOULD have tests that pass. I'm having a hard time testing this locally with the preset.