Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improv: shuffle indexablePages #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tomasz-stefaniak
Copy link

What did I change?

Shuffle indexablePages to prevent using API quota on checking the same pages over and over again

Why did I change it?

I want my quota to be used on checking new pages instead on rechecking the same pages

@goenning
Copy link
Owner

that shouldn't be necessary as there's a 14 days cache, so if a page is was checked a few minutes ago and the next page failed due to API Quota, the next run should start from the latest failed page. Is that not happening?

@tomasz-stefaniak
Copy link
Author

tomasz-stefaniak commented May 30, 2024

It's not, at least not in my case. It might be that the cache isn't working as expected then. I haven't reviewed the code very thoroughly but it looks like the cache is used to get the indexing status of all pages. I think any page with a non-indexed status gets an indexing request, whether it's present in the cache or not.

I'm not the only one running into this issue: https://x.com/charlestehio/status/1795505617341419532

Copy link
Contributor

@AntoineKM AntoineKM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's linked to another issue that needs to be investigated, I don't think this is a good idea to shuffle the array, it doesn't fix the initial problem.

@kolyasya
Copy link

kolyasya commented Jul 1, 2024

I have the same problem that the script goes through the same array of pages over and over again.

@goenning
Copy link
Owner

goenning commented Jul 1, 2024

I think this PR fixed this, no? #62

@kolyasya
Copy link

kolyasya commented Jul 1, 2024

I think this PR fixed this, no? #62

I'll double check. Meanwhile I was using this fork which shuffles pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants