Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid decoding plain text password when database secret exists #1675

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix: avoid decoding plain text password when database secret exists #1675

merged 1 commit into from
Jan 11, 2024

Conversation

barsa-net
Copy link
Contributor

Fixes #1674

@mkjpryor
Copy link

mkjpryor commented Jan 5, 2024

Can we please get this merged and in a release ASAP? Currently the behaviour is incorrect on both upgrade and new installations.

This was referenced Jan 5, 2024
Merged
Closed
@ywk253100 ywk253100 merged commit bd30675 into goharbor:main Jan 11, 2024
6 checks passed
@OrlinVasilev
Copy link
Member

@barsa-net congrats on merging your first PR here :)))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vad1mo Vad1mo Vad1mo approved these changes

@ywk253100 ywk253100 ywk253100 approved these changes

Assignees
No one assigned
Labels
needs/cherry-pick target/1.15.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Misbehaviour during upgrade
6 participants
@barsa-net @mkjpryor @OrlinVasilev @Vad1mo @ywk253100 @zyyw