Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

theme: Add anchor links via JS #2914

Merged
merged 1 commit into from
Feb 17, 2025
Merged

theme: Add anchor links via JS #2914

merged 1 commit into from
Feb 17, 2025

Conversation

bep
Copy link
Member

@bep bep commented Feb 16, 2025

This needs Hugo v0.144.0 to be released before merged.

/cc @jmooring

@bep bep force-pushed the feat/jsanchors branch 3 times, most recently from 44044b4 to 7fb60f8 Compare February 16, 2025 19:45
@jmooring
Copy link
Member

I added a dl to content/en/about/features.md, then clicked the link beneath it, then went back to original page, etc. The number of link icons increases by one each time.

Screencast.from.2025-02-16.18-23-48.webm

@bep
Copy link
Member Author

bep commented Feb 17, 2025

The number of link icons increases by one each time.

The more the merrier. Thanks, this is the Turbo cache that plays me a trick. I'll have a look at it.

@bep
Copy link
Member Author

bep commented Feb 17, 2025

I have pushed a fix for the "double anchors".

@bep bep force-pushed the feat/jsanchors branch 2 times, most recently from c550fc5 to c18098b Compare February 17, 2025 17:02
@bep bep marked this pull request as ready for review February 17, 2025 17:02
@bep bep merged commit 18e1aa9 into gohugoio:master Feb 17, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants