Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename .prettierrc to .prettierrc.json #2927

Closed
wants to merge 1 commit into from

Conversation

coliff
Copy link
Member

@coliff coliff commented Feb 18, 2025

This is recommended by Prettier itself and it adds syntax highlighting and linting to Prettier by adding the .json file extension.

This is recommended by Prettier itself and it adds syntax highlighting and linting to Prettier by adding the `.json` file extension.
@jmooring
Copy link
Member

This is recommended by Prettier itself

Can you provide a reference for this? All I can find is that .prettierrc has a higher precedence than .prettierrc.whatever.

https://prettier.io/docs/configuration

@coliff
Copy link
Member Author

coliff commented Feb 18, 2025

ah, sorry then! I thought it recommended it there in the docs. Perhaps they changed things around. Still, I think it's worthwhile for the syntax highlighting and linting but I'm fine if you want to close it for any reason...

@jmooring
Copy link
Member

syntax highlighting and linting

This is what I'm seeing, lexed and linted.

image

@coliff
Copy link
Member Author

coliff commented Feb 18, 2025

I can't quite understand what's going on there... When I force format that file with Prettier it makes no changes. There shouldn't be a comma after "singleQuote": true...

@jmooring
Copy link
Member

shouldn't be a comma after

Yeah, I put them there to show linting in effect. I think we can close this.

@coliff coliff closed this Feb 18, 2025
@coliff
Copy link
Member Author

coliff commented Feb 18, 2025

no problem :-)

@coliff coliff deleted the prettier-file-syntax-highlighting branch February 18, 2025 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants