Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The iota enum expression for sortMethod required the same lengthy switch statement in setExpression's
eval
andsetLocalExpression
's eval, along withgetOptsMap
in main to be updated for every sort method. Making sortMethod's underlying representation a string removes the need to have these long and repetitive switch statements and for new sortMethods to require changes outside ofdir.sort
innav.go
and the const definitions at the top ofopts.go
Alternatively,
sortMethod
can stay as an iota and there can be a map of sortMethods to their string representations.