feat: temlated shell command #1852
Draft
+794
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1784
WIP. I lost the track of this issue and have since fully switched away from windows and from nushell. Getting powershell, bash and cmd (especially cmd) to agree upon different things is challenging and requires a lot of cross-platform testing. Here is my progress so far. I made a big part of the issue along with the OS integration tests by launching the full
lfinside thetcell.NewSimulationScreen. However, there are many edge cases with escaping rules. The code is a little bit messy but I decided to open a draft anyway -- If someone is interested in this feature and willing to continue the work, that would be great