location: add cellular support with extended location example #729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 3b33bd3): https://golioth-firmware-sdk-doxygen-dev--pr729-location-cellu-joqlbjvz.web.app (expires Tue, 28 Jan 2025 19:03:35 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
mniestroj
force-pushed
the
location-cellular-combined
branch
3 times, most recently
from
c394b4a to
0463d0f
Compare
sam-golioth
reviewed
Jan 16, 2025
There was a problem hiding this comment.
Nice work @mniestroj! The logic for coming WiFi and cellular is really clean.
examples/zephyr/location/dts/bindings/modem/golioth,cellular-playback.yaml
Outdated
Show resolved
Hide resolved
GOLIOTH_LOCATION_FLAG_* are not part of public API, so move them to private header instead. This file will contain more flags related implementation in the future, so it will make public header cleaner and easier to understand. Signed-off-by: Marcin Niestroj <[email protected]>
golioth_location_*_append() is designed in a way that it cannot be called interchangably for example with "cell" and "wifi" data. Instead one needs to be finished before the other can be started. Track which technologies (e.g. "cell" or "wifi") have been started and finished. Do not allow to restart whatever has been finished. Signed-off-by: Marcin Niestroj <[email protected]>
Both WiFi and cellular examples will have lots of shared code. Additionally technology-specific code will be rather minimal, so there is little reason to keep examples separate. Another benefit to have a combined version is the future use case of having both technologies (wifi and cellular) supported on single platform. Signed-off-by: Marcin Niestroj <[email protected]>
Introduce support for Golioth cellular location service. Signed-off-by: Marcin Niestroj <[email protected]>
Move generic location API calls from WiFi specific functions to main() function. This will allow to encode technology specific information independently from each other, while there will be just one request to Golioth backend. Signed-off-by: Marcin Niestroj <[email protected]>
It is not a good idea to constantly request WiFi scans. Instead, introduce 5s interval between those. Signed-off-by: Marcin Niestroj <[email protected]>
Allow to run example with disabled WiFi support. Signed-off-by: Marcin Niestroj <[email protected]>
Just enable WiFi location automatically whenever platform supports WiFi as wireless technology. Enable WiFi when GOLIOTH_WIFI_PLAYBACK is selected. Signed-off-by: Marcin Niestroj <[email protected]>
Extend sample with cellular network cell towers collected over the city trip. This is a playback with configurable speed (1x by default) to quickly see results over time during testing (e.g. on a Grafana map plugin). Signed-off-by: Marcin Niestroj <[email protected]>
Add nRF91 specific cellular tower information fetching and use when requesting location data. Use current cell only for now, as that is the only information provided with the tested modem and SIM card. Leave logs for neighbour cells enabled, so that extending this sample in the future is easy. Signed-off-by: Marcin Niestroj <[email protected]>
mniestroj
force-pushed
the
location-cellular-combined
branch
from
0463d0f to
3b33bd3
Compare
sam-golioth
approved these changes
Jan 21, 2025
Code Coverage
|
Codecov ReportAttention: Patch coverage is
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce support for Golioth cellular location service.
Move
examples/zephyr/location/wifi/toexamples/zephyr/location/and extend it to supportcellular as well. Most of the code is shared between the two, so it will lower maintenance needed as
compared to having two separate examples. Additionally this gives the benefit to test (right now
only with
native_sim) getting location with information from those two technologies combined.Supersedes: #717