tests: settings: delay after connection for log flush #739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 9942283): https://golioth-firmware-sdk-doxygen-dev--pr739-add-settings-d-m9h8o88u.web.app (expires Wed, 05 Feb 2025 19:27:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: a9993e61697a3983f3479e468bcb0b616f9a0578 |
hasheddan
approved these changes
Jan 29, 2025
Code Coverage
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ |
mniestroj
approved these changes
Jan 29, 2025
sam-golioth
force-pushed
the
add_settings_delay
branch
from
679e661 to
35ba395
Compare
When registering settings during the HIL test, we get a flood of log messages. On some platforms this can overwhelm the log buffer and lead to dropped messages. If one of those dropped messages is the connection message that the test scripts wait for, the test will fail. Now, we add a small delay after registering the settings to give time for the log buffer to flush, and then send a new "settings registration complete" message for the test script to key off of. This ensures the test script receives the message, and increases the stability of the test. Signed-off-by: Sam Friedman <[email protected]>
sam-golioth
force-pushed
the
add_settings_delay
branch
from
35ba395 to
9942283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When registering settings during the HIL test, we get a flood of log messages. On some platforms this can overwhelm the log buffer and lead to dropped messages. If one of those dropped messages is the connection message that the test scripts wait for, the test will fail.
Now, we add a small delay after registering the settings to give time for the log buffer to flush, and then send a new "settings registration complete" message for the test script to key off of. This ensures the test script receives the message, and increases the stability of the test.
Resolves golioth/firmware-issue-tracker#737