DO NOT MERGE: just a diff between python and this repo #26
Conversation
|
Build succeeded (check pipeline). |
| {{- template "_internal/opengraph.html" . -}} | ||
| {{- template "_internal/google_news.html" . -}} |
There was a problem hiding this comment.
Incompatible with newer Hugo
| @@ -1,4 +1,3 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
Let's look at this separately. Keep as is for now.
| @@ -1,10 +1,4 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
How about search for GD.UI?
| @@ -1,14 +1,92 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
@czechian , please look at this and try to merge it.
| @@ -0,0 +1,18 @@ | |||
| {{/* PETR: Definition of the superheading tag */}} | |||
There was a problem hiding this comment.
Rename this and remove the hardcoded color, please
| @@ -1,6 +1,6 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
Please split this into two partials and create a switch for these two.
There was a problem hiding this comment.
Or we can have two latest versions (include dev in latest) and have a new devVersion partial or something like that...
| @@ -1,6 +1,4 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
This is just an old version - please update from GD.UI and merge it together
| @@ -1,13 +0,0 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
This is just design update - Dan didn't want to have red font
| @@ -1,4 +1,3 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
| @@ -1,22 +1,17 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
Use the one from docs theme, as it fixes nested shortcodes
| @@ -1,7 +1,10 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
We can overwrite this in the PySDK
| @@ -1,18 +1,13 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
Can be overwritten in PySDK
| @@ -0,0 +1,5 @@ | |||
| <tr> | |||
| @@ -0,0 +1,20 @@ | |||
| {{ $partitle := .Get "title"}} | |||
| @@ -1,4 +1,3 @@ | |||
| {{/* (C) 2023 GoodData Corporation */}} | |||
There was a problem hiding this comment.
Keep the newer version, fixes md-5
|
Please ping me when you are nearly done with this, as we would need to also update all the scss :) |
No description provided.