Skip to content

Commit

Permalink
Merge branch 'master' into lanctot-v1.5-python3.12
Browse files Browse the repository at this point in the history
  • Loading branch information
lanctot authored Apr 8, 2024
2 parents dfb75d9 + 1b09f3b commit bec4676
Show file tree
Hide file tree
Showing 67 changed files with 16 additions and 3,853 deletions.
10 changes: 2 additions & 8 deletions .github/workflows/actions.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,27 +14,24 @@ jobs:
# Most current platform.
- os: ubuntu-22.04
OS_PYTHON_VERSION: "3.11"
TRAVIS_USE_NOX: 0
DEFAULT_OPTIONAL_DEPENDENCY: "ON"
BUILD_SHARED_LIB: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS_DOWNLOAD_URL: ""
# Standard (most current) platforms and versions.
- os: ubuntu-22.04
OS_PYTHON_VERSION: "3.10"
TRAVIS_USE_NOX: 0
DEFAULT_OPTIONAL_DEPENDENCY: "ON"
BUILD_SHARED_LIB: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS: "ON"
OPEN_SPIEL_BUILD_WITH_ORTOOLS_DOWNLOAD_URL: "https://github.com/google/or-tools/releases/download/v9.6/or-tools_amd64_ubuntu-22.04_cpp_v9.6.2534.tar.gz"
- os: ubuntu-22.04
OS_PYTHON_VERSION: "3.10"
TRAVIS_USE_NOX: 0
DEFAULT_OPTIONAL_DEPENDENCY: "OFF"
BUILD_SHARED_LIB: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS_DOWNLOAD_URL: ""
- os: macos-14
- os: macos-13
OS_PYTHON_VERSION: "3.11"
TRAVIS_USE_NOX: 0
DEFAULT_OPTIONAL_DEPENDENCY: "OFF"
Expand All @@ -44,15 +41,13 @@ jobs:
# Standard or older platforms with older Python versions.
- os: macos-12
OS_PYTHON_VERSION: "3.9"
TRAVIS_USE_NOX: 0
DEFAULT_OPTIONAL_DEPENDENCY: "OFF"
BUILD_SHARED_LIB: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS_DOWNLOAD_URL: ""
- os: ubuntu-20.04
OS_PYTHON_VERSION: "3.9"
DEFAULT_OPTIONAL_DEPENDENCY: "ON"
TRAVIS_USE_NOX: 0
BUILD_SHARED_LIB: "ON"
OPEN_SPIEL_BUILD_WITH_ORTOOLS: "OFF"
OPEN_SPIEL_BUILD_WITH_ORTOOLS_DOWNLOAD_URL: ""
Expand All @@ -64,7 +59,6 @@ jobs:
OPEN_SPIEL_ENABLE_TENSORFLOW: ON
OPEN_SPIEL_ENABLE_PYTHON_MISC: ON
OS_PYTHON_VERSION: ${{ matrix.OS_PYTHON_VERSION }}
TRAVIS_USE_NOX: ${{ matrix.TRAVIS_USE_NOX }}
DEFAULT_OPTIONAL_DEPENDENCY: ${{ matrix.DEFAULT_OPTIONAL_DEPENDENCY }}
OPEN_SPIEL_BUILD_WITH_JULIA: ${{ matrix.OPEN_SPIEL_BUILD_WITH_JULIA }}
BUILD_SHARED_LIB: ${{ matrix.BUILD_SHARED_LIB }}
Expand All @@ -73,7 +67,7 @@ jobs:

steps:
- uses: actions/checkout@v4
- uses: julia-actions/setup-julia@v1
- uses: julia-actions/setup-julia@v2
with:
version: 1.8
- name: Ad-hoc fix
Expand Down
5 changes: 1 addition & 4 deletions docs/install.md
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,7 @@ issue.
Currently there are three installation methods:

1. building from the source code and editing `PYTHONPATH`.
2. using `pip install` to build and testing using
[nox](https://nox.thea.codes/en/stable/).
2. using `pip install`.
3. installing via [Docker](https://www.docker.com).

## Summary
Expand Down Expand Up @@ -136,8 +135,6 @@ In a nutshell:

```bash
python3 -m pip install .
python3 -m pip install nox
nox -s tests
```

Optionally, use `pip install -e` to install in
Expand Down
47 changes: 0 additions & 47 deletions noxfile.py

This file was deleted.

14 changes: 0 additions & 14 deletions open_spiel/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -113,8 +113,6 @@ openspiel_optional_dependency(OPEN_SPIEL_BUILD_WITH_GO OFF
"Build with support for Golang API.")
openspiel_optional_dependency(OPEN_SPIEL_BUILD_WITH_HANABI OFF
"Build against the Hanabi game.")
openspiel_optional_dependency(OPEN_SPIEL_BUILD_WITH_HIGC OFF
"Build with Hidden Information Game Competition tournament support.")
openspiel_optional_dependency(OPEN_SPIEL_BUILD_WITH_JULIA OFF
"Build binary for Julia.")
openspiel_optional_dependency(OPEN_SPIEL_BUILD_WITH_LIBNOP OFF
Expand All @@ -137,9 +135,6 @@ openspiel_optional_dependency(OPEN_SPIEL_BUILD_WITH_RUST OFF
"Build with support for Rust API.")

if (WIN32)
if (OPEN_SPIEL_BUILD_WITH_HIGC)
message(FATAL_ERROR "HIGC not supported in Windows, please disable it.")
endif()
openspiel_optional_dependency(OPEN_SPIEL_ENABLE_JAX OFF
"Enable JAX.")
openspiel_optional_dependency(OPEN_SPIEL_ENABLE_PYTORCH OFF
Expand Down Expand Up @@ -230,10 +225,6 @@ set (OPEN_SPIEL_OBJECTS
$<TARGET_OBJECTS:utils>
$<TARGET_OBJECTS:tests>
)
if (OPEN_SPIEL_BUILD_WITH_HIGC)
set(OPEN_SPIEL_OBJECTS ${OPEN_SPIEL_OBJECTS}
$<TARGET_OBJECTS:higc>)
endif()
if (OPEN_SPIEL_BUILD_WITH_HANABI)
set(OPEN_SPIEL_OBJECTS ${OPEN_SPIEL_OBJECTS}
$<TARGET_OBJECTS:hanabi_learning_environment>)
Expand Down Expand Up @@ -317,11 +308,6 @@ endif()

if (OPEN_SPIEL_BUILD_WITH_PYTHON)
add_subdirectory (python)
# HIGC needs pyspiel.so and corresponding PYTHONPATH to be set
# in order to run its tests.
if (OPEN_SPIEL_BUILD_WITH_HIGC)
add_subdirectory (higc)
endif()
endif()

add_subdirectory (utils)
Expand Down
4 changes: 0 additions & 4 deletions open_spiel/games/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -206,10 +206,6 @@ if (${OPEN_SPIEL_BUILD_WITH_GAMUT})
add_subdirectory(gamut)
endif()


# Uncomment to build the Ludii demo
# add_subdirectory (ludii)

add_library(bridge_double_dummy_solver OBJECT
bridge/double_dummy_solver/include/dll.h
bridge/double_dummy_solver/include/portab.h
Expand Down
36 changes: 0 additions & 36 deletions open_spiel/games/ludii/CMakeLists.txt

This file was deleted.

32 changes: 0 additions & 32 deletions open_spiel/games/ludii/README.md

This file was deleted.

51 changes: 0 additions & 51 deletions open_spiel/games/ludii/chunk_set.cc

This file was deleted.

41 changes: 0 additions & 41 deletions open_spiel/games/ludii/chunk_set.h

This file was deleted.

Loading

0 comments on commit bec4676

Please sign in to comment.