Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add license header checking app #404

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Add license header checking app #404

merged 2 commits into from
Jan 14, 2025

Conversation

markmcd
Copy link
Member

@markmcd markmcd commented Jan 13, 2025

Giom-V
Giom-V previously approved these changes Jan 13, 2025
Copy link
Collaborator

@Giom-V Giom-V left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but have you run it on the existing .py files? Do we need to update their licences?

@markmcd
Copy link
Member Author

markmcd commented Jan 14, 2025

Approved, but have you run it on the existing .py files? Do we need to update their licences?

Yeah, they will need to be updated too. Typically I would do the "prevent backsliding" step before the "update the world" step, since they're independent, but it looks like there's only the file-api samples so I'll update it here.

@Giom-V Giom-V merged commit 5d28805 into main Jan 14, 2025
3 checks passed
@markmcd markmcd deleted the macd-header-checker branch January 15, 2025 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants