fix: Disallow and ignore x and y attributes for blocks in toolbox definitions. #8785
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gonfunko
changed the title
gonfunko
commented
Feb 25, 2025
There was a problem hiding this comment.
Confirmed the positioning logic needs no change after this; it assumes items are initially at (0, 0) and moves them relative to that point, which was problematic when they were starting at not-(0, 0) due to the x and y properties being respected, but is no longer an issue.
|
Thanks @gonfunko. Just had one suggestion on clarifying a comment for clearer context, otherwise the PR LGTM. |
BenHenning
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Fixes #6280
Proposed Changes
This PR removes
xandyfromBlockInfo, and removes them if set before loading and laying out blocks in a flyout. Previously, these would cause blocks to be positioned incorrectly in the flyout, since the flyout repositions its contents relative to one another but assumes their initial origin is (0, 0). The XML codepath was not subject to this issue.