Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix a bug where selection outlines could be cut off when connecting blocks. #8789

Merged
merged 1 commit into from
Feb 27, 2025

Conversation

gonfunko
Copy link
Contributor

@gonfunko gonfunko commented Feb 27, 2025

The basics

The details

Resolves

Fixes #8787

Proposed Changes

This PR un- and re-selects selected blocks when they are connected to another block. This fixes the z-ordering of the selection highlight path relative to other blocks, which prevents it from becoming partially obscured.

@gonfunko gonfunko requested a review from cpcallen February 27, 2025 20:42
@gonfunko gonfunko requested a review from a team as a code owner February 27, 2025 20:42
@gonfunko gonfunko merged commit dcd2d0e into google:develop Feb 27, 2025
8 of 12 checks passed
@gonfunko gonfunko deleted the zelos-outlines branch February 27, 2025 21:19
@gonfunko gonfunko added the PR: fix Fixes a bug label Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: fix Fixes a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Block selection indicator partially obscured in Zelos renderer
3 participants