Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure examples compile on latest version of AOSP #2414

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Ensure examples compile on latest version of AOSP #2414

merged 1 commit into from
Oct 28, 2024

Conversation

mgeisler
Copy link
Collaborator

This is part of #2398.

@mgeisler mgeisler requested a review from randomPoison October 28, 2024 13:41
randomPoison
randomPoison approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@randomPoison randomPoison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah thanks for fixing this, I haven't had a chance to fix up the Android example code yet.

@mgeisler mgeisler merged commit 7a462ef into main Oct 28, 2024
37 checks passed
@mgeisler mgeisler deleted the fix-aosp-compile-errors branch October 28, 2024 18:35
@mgeisler
Copy link
Collaborator Author

No problem! In case you have some spare cycles, #2398 finally has some ideas for how to test this: just add it to AOSP 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randomPoison randomPoison randomPoison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgeisler @randomPoison