Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use dbg! instead of println! in Day 1 mng session #2652

Merged
merged 3 commits into from
Feb 24, 2025

Conversation

egithinji
Copy link
Contributor

As mentioned in #2478, this cleans up the code blocks when all that is needed is a trivial debug print statement.
Only making changes to Day 1 morning session so that I can get feedback before proceeding with the rest of the course.

@djmitche djmitche linked an issue Feb 21, 2025 that may be closed by this pull request
Copy link
Collaborator

@djmitche djmitche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! A minor issue is that the line numbers don't add up, I think because we are injecting #![allow(..)]. I can make a PR to fix that.

@djmitche
Copy link
Collaborator

Looks like it needs a dprint fmt run before it can be merged..

@egithinji
Copy link
Contributor Author

Looks like it needs a dprint fmt run before it can be merged..

Done. Thank you for the review and also for the line numbering fix!

@djmitche djmitche enabled auto-merge (squash) February 24, 2025 14:04
@djmitche djmitche merged commit 0daab17 into google:main Feb 24, 2025
35 checks passed
egithinji added a commit to egithinji/comprehensive-rust that referenced this pull request Feb 25, 2025
As mentioned in google#2478, this cleans up the code blocks when all that is
needed is a trivial debug print statement.
Only making changes to Day 1 morning session so that I can get feedback
before proceeding with the rest of the course.

---------

Co-authored-by: Eric Githinji <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants