-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new PMP canonical type and extend RMM abstract type #1001
base: master
Are you sure you want to change the base?
Conversation
implements: | ||
- PMP | ||
- CPC | ||
- RMM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
RMM
is typically reserved for components that perform heating/cooling. It is odd to see this used on a pump.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated to PMP_SS_RMM_CPC for now. If its prefered to not use RMM, PMP_VSC_CPC could possible work if run_command
and speed_percentage_command
are marked missing, but unsure if using VSC and marking speed_percentage_command
as missing would be valid.
- PMP | ||
- SS | ||
- RMM | ||
- CPC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CPC
should be used on non-PMP types. For example, if a boiler had a pump that was internal to the unit. Can you please clarify; are you trying to model a stand-alone pump or a circulation pump that is inside of another piece of equipment?
@adelin-diac please clarify if this pump is a stand-alone pump or if it is part of another piece of equipment (for example: a circulation pump on a boiler). If this is a stand-alone pump, you cannot use Can you please expand on the need to use |
@cstirdivant apologies about delay with this device. There was some slight misunderstanding at the time of modelling this device. It is actually an air source heat pump, which serves domestic hot water. It has a circulation pump on it. Which type would be best to use in this case, PMP or create a general type for ASHP? |
In terms of the
|
No description provided.