Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new PMP canonical type and extend RMM abstract type #1001

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

adelin-diac
Copy link
Contributor

No description provided.

@adelin-diac adelin-diac changed the title new DWST canonical type and extend RMM abstract type new PMP canonical type and extend RMM abstract type Apr 3, 2023
@adelin-diac adelin-diac marked this pull request as ready for review April 4, 2023 07:44
@mschulze17 mschulze17 added the P2 Medium priority (default) label Apr 5, 2023
@cstirdivant cstirdivant removed the request for review from tasodorff June 14, 2023 23:30
implements:
- PMP
- CPC
- RMM
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RMM is typically reserved for components that perform heating/cooling. It is odd to see this used on a pump.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated to PMP_SS_RMM_CPC for now. If its prefered to not use RMM, PMP_VSC_CPC could possible work if run_command and speed_percentage_command are marked missing, but unsure if using VSC and marking speed_percentage_command as missing would be valid.

- PMP
- SS
- RMM
- CPC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CPC should be used on non-PMP types. For example, if a boiler had a pump that was internal to the unit. Can you please clarify; are you trying to model a stand-alone pump or a circulation pump that is inside of another piece of equipment?

@cstirdivant
Copy link
Collaborator

@adelin-diac please clarify if this pump is a stand-alone pump or if it is part of another piece of equipment (for example: a circulation pump on a boiler). If this is a stand-alone pump, you cannot use CPC (as this is reserved for pumps as part of another piece of equipment).

Can you please expand on the need to use RMM? What types of modes are you seeing other than ON/OFF?

@adelin-diac
Copy link
Contributor Author

@cstirdivant apologies about delay with this device. There was some slight misunderstanding at the time of modelling this device. It is actually an air source heat pump, which serves domestic hot water. It has a circulation pump on it. Which type would be best to use in this case, PMP or create a general type for ASHP?

@adelin-diac adelin-diac removed their assignment Jul 20, 2023
@adelin-diac
Copy link
Contributor Author

In terms of the run_mode states, the ones given to us are:

  • System Off
  • System On
  • Emergency Run
  • Test Run

@cstirdivant cstirdivant added the Ontology Model Extensions or edits to the ontology model label Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ontology Model Extensions or edits to the ontology model P2 Medium priority (default)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants