Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add alignas specifier to buffer in explicit alignment test. #216

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Add alignas specifier to buffer in explicit alignment test. #216

merged 2 commits into from
Dec 19, 2024

Conversation

reventlov
Copy link
Collaborator

@reventlov reventlov commented Dec 19, 2024 •
edited
Loading

This fixes the clang test failures.

Also update workflow to emit test logs on failure.

@reventlov reventlov changed the title Update workflow to emit test logs on failure. Add alignas specifier to buffer in explicit alignment test. Dec 19, 2024
@reventlov reventlov requested a review from EricRahm December 19, 2024 23:00
EricRahm
EricRahm approved these changes Dec 19, 2024
View reviewed changes
Copy link
Collaborator

@EricRahm EricRahm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh nice catch!

@reventlov reventlov merged commit 615a955 into google:master Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricRahm EricRahm EricRahm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reventlov @EricRahm