Skip to content

Commit

Permalink
Fix warnings on Build .NET Windows
Browse files Browse the repository at this point in the history
  • Loading branch information
dbaileychess committed Jan 10, 2025
1 parent 99fda81 commit a96fe8f
Show file tree
Hide file tree
Showing 2 changed files with 21 additions and 2 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -203,15 +203,15 @@ jobs:
steps:
- uses: actions/checkout@v3
- name: Setup .NET Core SDK
uses: actions/setup-dotnet@v3
uses: actions/setup-dotnet@v4.2
with:
dotnet-version: '8.0.x'
- name: Build
run: |
cd tests\FlatBuffers.Test
dotnet new sln --force --name FlatBuffers.Test
dotnet sln FlatBuffers.Test.sln add FlatBuffers.Test.csproj
dotnet build -c Release ${{matrix.configuration}} -o out FlatBuffers.Test.sln
dotnet build -c Release ${{matrix.configuration}} --property:PublishDir=out FlatBuffers.Test.sln
- name: Run
run: |
cd tests\FlatBuffers.Test
Expand Down
19 changes: 19 additions & 0 deletions docs/source/building.md
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,20 @@ Use `cmake` to configure a project based on your environment and platform.
cmake -G "Xcode" -DCMAKE_BUILD_TYPE=Release
```

#### Strict Mode

By default, `cmake` will configure targets to **not** build with strict warnings
on (e.g. `-Werror` or `/WX`). This may cause into issues when submitting code
changes since our CI requires the code to compile in strict mode.

To enable the extra warnings, turn on strict mode with the
`FLATBUFFERS_STRICT_MODE` cmake option.

```cmake
cmake -DFLATBUFFERS_STRICT_MODE=ON
```


### Building

Once the project files are generated, build as normal for your platform.
Expand All @@ -56,6 +70,11 @@ Once the project files are generated, build as normal for your platform.
xcodebuild -toolchain clang -configuration Release
```






## Building with Bazel

## Building with VCPKG

0 comments on commit a96fe8f

Please sign in to comment.