Add alwayslink=1 to //src:flatc to fix Windows build failure. #8088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkinsp
added a commit
to hawkinsp/jax
that referenced
this pull request
Sep 7, 2023
Use upstream flatbuffer bazel scripts, with a couple of small patches to fix: * google/flatbuffers#8087 (remove npm references) * google/flatbuffers#8088 (fix flatc build failure due to main() removal by linker)
hawkinsp
added a commit
to hawkinsp/jax
that referenced
this pull request
Sep 7, 2023
Use upstream flatbuffer bazel scripts, with a couple of small patches to fix: * google/flatbuffers#8087 (remove npm references) * google/flatbuffers#8088 (fix flatc build failure due to main() removal by linker)
hawkinsp
added a commit
to hawkinsp/jax
that referenced
this pull request
Sep 7, 2023
Use upstream flatbuffer bazel scripts, with a couple of small patches to fix: * google/flatbuffers#8087 (remove npm references) * google/flatbuffers#8088 (fix flatc build failure due to main() removal by linker)
copybara-service bot
pushed a commit
to jax-ml/jax
that referenced
this pull request
Sep 7, 2023
-- 3905d61 by Peter Hawkins <[email protected]>: Update flatbuffers. Use upstream flatbuffer bazel scripts, with a couple of small patches to fix: * google/flatbuffers#8087 (remove npm references) * google/flatbuffers#8088 (fix flatc build failure due to main() removal by linker) COPYBARA_INTEGRATE_REVIEW=#17502 from hawkinsp:fb 3905d61 PiperOrigin-RevId: 563543954
dbaileychess
approved these changes
Nov 18, 2023
When built on Windows, the main() symbol ends up stripped out of the //:flatc binary unless the library containing main() is tagged alwayslink=1.
dbaileychess
force-pushed
the
windows
branch
from
4134eac to
d2649ce
Compare
|
can you run the build cleaner for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When built on Windows, the main() symbol ends up stripped out of the //:flatc binary unless the library containing main() is tagged alwayslink=1.