-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spelling #8177
base: master
Are you sure you want to change the base?
Spelling #8177
Conversation
Can you run the generated code script? |
Not easily?
|
Note the output I'm seeing in the workflow run seem to indicate that something is going fairly wrong... diff --git a/tests/MyGame/Example/Monster.php b/tests/MyGame/Example/Monster.php
index 2b02d8a..4464940 100644
--- a/tests/MyGame/Example/Monster.php
+++ b/tests/MyGame/Example/Monster.php
@@ -125,7 +125,7 @@ class Monster extends Table
}
/**
- * @return int
+ * @returnint
*/
public function getTest($obj)
{ |
tests/MyGame/Example/Monster.php
Outdated
* @returnint | ||
* @return int |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are reverted by flatc
as part of scripts/generate_code.py
-- I don't understand why, but, oh well.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember what caused this file to be touched (as noted elsewhere, I try not to touch files because my editors like wiping out whitespace...), but this change was undone by 29f08c9
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
This pull request is stale because it has been open 6 months with no activity. Please comment or label |
I can try to refresh this... |
I've made changes but haven't actually tried building it, sorry. I can do that later...
Technically yes, but I haven't changed anything meaningful.
Fixes misspellings identified by the check-spelling action.
The misspellings have been reported at https://github.com/jsoref/flatbuffers/actions/runs/6999931216/attempts/1#summary-19039873159
The action will report that the changes in this PR would make it happy: https://github.com/jsoref/flatbuffers/actions/runs/6999931239/attempts/1#summary-19039873164