Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #8177

Open
wants to merge 178 commits into
base: master
Choose a base branch
from
Open

Spelling #8177

wants to merge 178 commits into from

Conversation

jsoref
Copy link

@jsoref jsoref commented Nov 27, 2023

If you make changes to any of the code generators (src/idl_gen*) be sure to
build your project, as it will generate code based on the changes. If necessary
the code generation script can be directly run (scripts/generate_code.py),
requires Python3. This allows us to better see the effect of the PR.

I've made changes but haven't actually tried building it, sorry. I can do that later...

If your PR includes C++ code, please adhere to the
Google C++ Style Guide,
and don't forget we try to support older compilers (e.g. VS2010, GCC 4.6.3),
so only some C++11 support is available.

Technically yes, but I haven't changed anything meaningful.


Fixes misspellings identified by the check-spelling action.

The misspellings have been reported at https://github.com/jsoref/flatbuffers/actions/runs/6999931216/attempts/1#summary-19039873159

The action will report that the changes in this PR would make it happy: https://github.com/jsoref/flatbuffers/actions/runs/6999931239/attempts/1#summary-19039873164

.github/labeler.yml Show resolved Hide resolved
.github/workflows/build.yml Show resolved Hide resolved
docs/source/Benchmarks.md Show resolved Hide resolved
docs/source/CppUsage.md Show resolved Hide resolved
net/FlatBuffers/FlatBufferVerify.cs Show resolved Hide resolved
tests/parser_test.cpp Show resolved Hide resolved
tests/type_field_collision.fbs Show resolved Hide resolved
tests/type_field_collsion.fbs Outdated Show resolved Hide resolved
tests/type_field_collision/Collision.cs Outdated Show resolved Hide resolved
docs/source/RustUsage.md Show resolved Hide resolved
dbaileychess
dbaileychess previously approved these changes Dec 19, 2023
@dbaileychess
Copy link
Collaborator

Can you run the generated code script? script/generate_code.py

@jsoref
Copy link
Author

jsoref commented Dec 19, 2023

Not easily?

AssertionError: Cannot find the flatc compiler /Users/jsoref/code/google/flatbuffers/flatc

@jsoref
Copy link
Author

jsoref commented Dec 19, 2023

Note the output I'm seeing in the workflow run seem to indicate that something is going fairly wrong...
https://github.com/google/flatbuffers/actions/runs/6999951158/job/19772665038#step:4:13

diff --git a/tests/MyGame/Example/Monster.php b/tests/MyGame/Example/Monster.php
index 2b02d8a..4464940 100644
--- a/tests/MyGame/Example/Monster.php
+++ b/tests/MyGame/Example/Monster.php
@@ -125,7 +125,7 @@ class Monster extends Table
     }
 
     /**
-     * @return int
+     * @returnint
      */
     public function getTest($obj)
     {

* @returnint
* @return int
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are reverted by flatc as part of scripts/generate_code.py -- I don't understand why, but, oh well.


Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember what caused this file to be touched (as noted elsewhere, I try not to touch files because my editors like wiping out whitespace...), but this change was undone by 29f08c9

Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Signed-off-by: Josh Soref <[email protected]>
Copy link
Contributor

This pull request is stale because it has been open 6 months with no activity. Please comment or label not-stale, or this will be closed in 14 days.

@github-actions github-actions bot added the stale label Sep 24, 2024
@jsoref
Copy link
Author

jsoref commented Sep 24, 2024

I can try to refresh this...

@github-actions github-actions bot removed the stale label Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants