Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix license details #8210

Closed
wants to merge 1 commit into from
Closed

Fix license details #8210

wants to merge 1 commit into from

Conversation

nfriedly
Copy link

@nfriedly nfriedly commented Jan 9, 2024

We updated to the latest release of the flatbuffers javascript library from npm, and Arnica threw up a warning that flatbuffers was using a non-standard license. However you're actually using a completely standard Apache 2.0 license, it was just mislabeled. (I diffed it against https://www.apache.org/licenses/LICENSE-2.0.txt to be sure and noticed that it didn't even have the copyright info filled in!)

So, this PR fixes two things:

  1. package.json now uses the correct SPDX license identifier.
  2. The copyright year and owner in the LICENSE file is now filled in

Feel free to edit that as appropriate. I can also split this into two PRs if preferred.

Copy link

google-cla bot commented Jan 9, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@nfriedly
Copy link
Author

nfriedly commented Jan 9, 2024

I am now a member of FullStory's corporate CLA group, but I'm not sure how to refresh the check here to recognize that. Nevermind, found the link at the bottom of of the cla check failure message.

@p0fi
Copy link
Contributor

p0fi commented Mar 11, 2024

Could this pull request be merged? We are experiencing a similar issue with our license scan, which is complaining about the license not being allowed, even though it is actually completely allowed.

LICENSE Outdated
@@ -187,7 +187,7 @@
same "printed page" as the copyright notice for easier
identification within third-party archives.

Copyright [yyyy] [name of copyright owner]
Copyright 2024 Alphabet Inc.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not needed I don't think.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I dropped that commit and rebased off of master, so it's just the package.json change now

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ugh, CI failed with what looks to be a networking issue. I don't think I have permission to restart it, do you?

This is useful for automated tools that scan for license requirements, and will also allow https://www.npmjs.com/package/flatbuffers to show the correct license info.

See https://docs.npmjs.com/cli/v10/configuring-npm/package-json#license
@dbaileychess
Copy link
Collaborator

Fixed: #8253

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants